ADX in 1 min chart Calulated every 5 min

[buzybill]

I have an efs below. This efs is going to be on 1 min charts, however I want to make this part of efs make it's calculation every five min. Then I want to have other part to calculate once ever on min. Is there way to do this? I'm doing this because this efs takes too much time.

Thanks

function preMain() {
setPriceStudy(true);
setStudyTitle("ADX Test II");
setCursorLabelName("ADX Test II");
setColorPriceBars(true);
setDefaultPriceBarColor(Color.blue);
setComputeOnClose();
}

function main() {

Symbol = getSymbol();
Interval = 5;
var vSymbol = Symbol+","+Interval;
hADX = adx(14,14,sym(vSymbol));
hPDI = pdi(14,14,sym(vSymbol));
hNDI = ndi(14,14,sym(vSymbol));

if (
hPDI > hNDI &&
hPDI > hADX
) {
setPriceBarColor(Color.lime);
}
}[COLOR=darkblue]

[eSignal_JasonK]

Hello buzybill,

There may be a better solution than what you are asking for. First try the modified example below. This code is using an initialization routine that will occur only once to set up your indicators and assign them to global variables. After they have been established all you should need to do is reference the values of the series with the .getValue() method.

One of the issues in your original code that may have been causing inefficiency is the fact that you were initializing the series implicitly (i.e. without var). Placing the initialization inside a bInit routine and assigning the series to global variables should help.

function preMain() {
    setPriceStudy(true);
    setStudyTitle("ADX Test II");
    setCursorLabelName("ADX Test II");
    setColorPriceBars(true);
    setDefaultPriceBarColor(Color.blue);
    setComputeOnClose();
}

// initialization flag
var bInit = false;

// global variables for series objects
var xADX = null;    
var xPDI = null;
var xNDI = null;

function main() {
    
    if (bInit == false) {  // initialization routine occurs only once.
        Symbol = getSymbol();
        Interval = 5;
        var vSymbol = Symbol+","+Interval;
        xADX = adx(14,14,sym(vSymbol));
        xPDI = pdi(14,14,sym(vSymbol));
        xNDI = ndi(14,14,sym(vSymbol));
        bInit = true;
    }
    
    var hADX = xADX.getValue(0);
    var hPDI = xPDI.getValue(0);
    var hNDI = xNDI.getValue(0);
    if (hADX == null || hPDI == null || hNDI == null) return; // null check
    
    if (hPDI > hNDI && hPDI > hADX) {
        setPriceBarColor(Color.lime); 
    }
    
    return;
} 

[MacDaddy]

Hi Jason,

If I wanted to use your formula to show a rising ADX what would I need to do?

I tried the following but I could not get it to work.

if (hADX > hADX) {
setPriceBarColor(Color.lime);


Thanks,
Dave

[eSignal_JasonK]

Hello Dave,

The condition as you've written it is comparing the hADX variable to itself, which will always evaluate to false. Use the .getValue() method of the Series Object to reference the previous bar's value and compare it to the current bar's value, which is assigned to the hADX variable. Try the following condition.

if (hADX > xADX.getValue(-1)) {  // adx is rising
    setPriceBarColor(Color.lime);
} 

[MacDaddy]

Hi Jason,

I tried to turn your efs into a plotted study. I did not get any syntax errors but I can not get it to plot the study lines. Please let me know what I did wrong.

Thanks,
Dave

function preMain() {
    setPriceStudy(false);
    setStudyTitle("ADXRisingColorBar");
    setCursorLabelName("ADX", 0);
    setCursorLabelName("DM+", 1);
    setCursorLabelName("DM-", 2);
    setDefaultBarFgColor(Color.magenta, 0);
    setDefaultBarFgColor(Color.green, 1);
    setDefaultBarFgColor(Color.red, 2);
    setDefaultBarThickness(2, 0);
    setDefaultBarThickness(1, 1);
    setDefaultBarThickness(1, 2);
    setPlotType(PLOTTYPE_LINE, 0);
    setPlotType(PLOTTYPE_LINE, 1);
    setPlotType(PLOTTYPE_LINE, 2);
    /*setComputeOnClose();*/
}

// initialization flag
var bInit = false;

// global variables for series objects
var xADX = null;    
var xPDI = null;
var xNDI = null;

function main() {
    
    if (bInit == false) {  // initialization routine occurs only once.
        Symbol = getSymbol();
        Interval = 1;
        var vSymbol = Symbol+","+Interval;
        xADX = adx(10,10,sym(vSymbol));
        xPDI = pdi(10,10,sym(vSymbol));
        xNDI = ndi(10,10,sym(vSymbol));
        bInit = true;
    }
    
    var hADX = xADX.getValue(0);
    var hPDI = xPDI.getValue(0);
    var hNDI = xNDI.getValue(0);
    if (hADX == null || hPDI == null || hNDI == null) return; // null check
    
    if (hADX > xADX.getValue(-1) 
    && hPDI > hNDI) {
    setBarFgColor(Color.lime, 0);
    }
    
    else if (hADX > xADX.getValue(-1) 
    && hNDI > hPDI) {
    setBarFgColor(Color.red, 0);  
    } 
    
     return new Array(
        hADX.getValue(xADX),
        hPDI.getValue(xPDI),
        hNDI.getValue(xNDI)
    );
   
} 

[eSignal_JasonK]

Hello David,

Try changing your return statement to the following. The .getValue() method is expecting a bar index value rather than a series object variable.

     return new Array(
        xADX.getValue(0),
        xPDI.getValue(0),
        xNDI.getValue(0)
    ); 

or

     return new Array(
        hADX,
        hPDI,
        hNDI
    ); 

[MacDaddy]

Hi Jason,

Thanks for your help!!!

The following worked perfectly (as you suggested):

PHP:

return new Array(
hADX,
hPDI,
hNDI
);

Very Best,
Dave