Problem with study?

[Seshadri]

Jason,

I am getting wierd plots for the Wilson RPC study totally unlike the one you have. I have tried it on different timeframe with the same result. Can you please tell me if I am doing something wrong? I have attached a picture of what I am getting FYI. I have not changed any of the default settings. Thanks in advance.

Sesh

[pmurraymc]

I think it is to do with the scaling of the chart, I will find my copy that I edited and post it.

Paul Murray

[pmurraymc]

Here are the changes I made to the code.

function calcRPC(nPeriods, nSmoothing, nOB, nOS, nUpperNZ, nLowerNZ) {
    var nC = close(0);
    var OB = ema(nSmoothing, efsInternal("calcCord", nPeriods, nOB),      0);
    var UN = ema(nSmoothing, efsInternal("calcCord", nPeriods, nUpperNZ), 0);
    var LN = ema(nSmoothing, efsInternal("calcCord", nPeriods, nLowerNZ), 0);
    var OS = ema(nSmoothing, efsInternal("calcCord", nPeriods, nOS),      0);
    
    OB = nC - (nC * (OB/10000));
    UN = nC - (nC * (UN/10000));
    LN = nC - (nC * (LN/10000));
    OS = nC - (nC * (OS/10000));
    
    return new Array(OB, UN, LN, OS);
} 

It is just a matter of changing the denominator to the calculation shown.

If I get time I will make a version with a denominator parameter, so it can be used on Forex, stocks, indices etc.

If anybody wants to beat me to it they are welcome, but am going to watch some cricket later this morning (note my location).

Paul Murray

[Seshadri]

Wilson RPC efs

Hi Paul,

Thanks for taking a look at the code. Hi Buzz, please find attached the efs that Jason put out based on the Stocks & Commodities magazine article. Hope you guys ca fix it. Thanks.

Sesh

[buzzhorton]

See if this helps.

I added button, colors and decimals with rounding.

/***************************************
Provided By : eSignal (c) Copyright 2006
Description:  The Wilson Relative Price Channel
              by Leon Wilson

Version 1.0  05/05/2006

Notes:
* July 2006 Issue of Stocks and Commodities Magazine
* Study requires version 7.9.1 or higher.


Formula Parameters:                 Defaults:
Channel Periods                     34
Smoothing Periods                   1
Over Bought                         70
Over Sold                           30
Upper Neutral Zone                  55
Lower Neutral Zone                  45



*************************************

TRO_wilson_rpc 20060730  ADDED BUTTON, ROUNDING INPUT,  COLOR INPUT

***************************************/


function preMain() {
    setPriceStudy(true);
    setStudyTitle("The Wilson Relative Price Channel ");
    setCursorLabelName("Over Bought", 0);
    setCursorLabelName("Neutral Upper", 1);
    setCursorLabelName("Neutral Lower", 2);
    setCursorLabelName("Over Sold", 3);
    setShowTitleParameters(false);
    setDefaultBarFgColor(Color.black, 0);
    setDefaultBarFgColor(Color.black, 1);
    setDefaultBarFgColor(Color.black, 2);
    setDefaultBarFgColor(Color.black, 3);
    setPlotType(PLOTTYPE_SQUAREWAVE, 0);
    setPlotType(PLOTTYPE_SQUAREWAVE, 1);
    setPlotType(PLOTTYPE_SQUAREWAVE, 2);
    setPlotType(PLOTTYPE_SQUAREWAVE, 3);
    


    var iDecimals = new FunctionParameter("iDecimals", FunctionParameter.NUMBER);
    iDecimals.setName("Round to X decimals");
        iDecimals.setDefault( 2 ); 



    var iColorTop = new FunctionParameter("iColorTop", FunctionParameter.COLOR);
        iColorTop.setDefault( Color.lightgrey );
 
    var iColorBottom = new FunctionParameter("iColorBottom", FunctionParameter.COLOR);
        iColorBottom.setDefault( Color.darkgrey );

    var iButtonX = new FunctionParameter("iButtonX", FunctionParameter.NUMBER);
    iButtonX.setDefault( 5 ); 

    var iButtonY = new FunctionParameter("iButtonY", FunctionParameter.NUMBER);
    iButtonY.setDefault( 15 ); 


    var fp1 = new FunctionParameter("nPeriods", FunctionParameter.NUMBER);
        fp1.setName("Channel Periods");
        fp1.setLowerLimit(1);
        fp1.setUpperLimit(250);
        fp1.setDefault(34);
    var fp2 = new FunctionParameter("nSmoothing", FunctionParameter.NUMBER);
        fp2.setName("Smoothing Periods");
        fp2.setLowerLimit(1);
        fp2.setUpperLimit(55);
        fp2.setDefault(1);
    var fp3 = new FunctionParameter("nOB", FunctionParameter.NUMBER);
        fp3.setName("Over Bought");
        fp3.setLowerLimit(50);
        fp3.setUpperLimit(99);
        fp3.setDefault(70);
    var fp4 = new FunctionParameter("nOS", FunctionParameter.NUMBER);
        fp4.setName("Over Sold");
        fp4.setLowerLimit(1);
        fp4.setUpperLimit(50);
        fp4.setDefault(30);
    var fp5 = new FunctionParameter("nUpperNZ", FunctionParameter.NUMBER);
        fp5.setName("Upper Neutral Zone");
        fp5.setLowerLimit(50);
        fp5.setUpperLimit(99);
        fp5.setDefault(55);
    var fp6 = new FunctionParameter("nLowerNZ", FunctionParameter.NUMBER);
        fp6.setName("Lower Neutral Zone");
        fp6.setLowerLimit(1);
        fp6.setUpperLimit(50);
        fp6.setDefault(45);
}



var bVersion = null;
var bInit = false;

var xRPC = null;

function main( iDecimals, iColorTop, iColorBottom, iButtonX, iButtonY,
               nPeriods, nSmoothing, nOB, nOS, nUpperNZ, nLowerNZ ) {    

    if (bVersion == null) bVersion = verify();
    if (bVersion == false) return;    

  // initialize upon first loading formula
    if(getBarState() == BARSTATE_ALLBARS) {
        drawTextPixel(5, 75, " TRO_wilson_rpc @URL=EFS:editParameters", Color.white, Color.green, 
            Text.RELATIVETOLEFT|Text.RELATIVETOBOTTOM|Text.ONTOP|Text.BOLD|Text.BUTTON, 
            "Comic Sans MS", 13, "UpExp"); 
        vDate = new Date();
        vInterval = getInterval();
        vSymbol = getSymbol().toUpperCase();
    
        // for RTH, eg, to convert, ES Z2 to ES Z2=2
        var rootSymbol = vSymbol.substring(0,3);
        if (rootSymbol == "ES " || rootSymbol == "NQ ") 
            if ( vSymbol.indexOf("=2") == -1 ) vSymbol += "=2";
    
        vSymbol += ",D";
        return null;
    }




    if (bInit == false) {
        xRPC = efsInternal("calcRPC", nPeriods, nSmoothing, nOB, nOS, nUpperNZ, nLowerNZ, iDecimals);
        bInit = true;
    }
    
    var nRPC_OB = getSeries(xRPC, 0);  // Over Bought
    nRPC_OB = rnd( nRPC_OB , iDecimals ) ;

    var nRPC_UN = getSeries(xRPC, 1);  // Upper Neutral
    nRPC_UN = rnd( nRPC_UN , iDecimals ) ;

    var nRPC_LN = getSeries(xRPC, 2);  // Lower Neutral
    nRPC_LN = rnd( nRPC_LN , iDecimals ) ;

    var nRPC_OS = getSeries(xRPC, 3);  // Over Sold
    nRPC_OS = rnd( nRPC_OS , iDecimals ) ;



    setBarBgColor( iColorTop, 0, nRPC_UN, nRPC_OB);
    setBarBgColor( iColorBottom, 2, nRPC_LN, nRPC_OS);

    return new Array(nRPC_OB, nRPC_UN, nRPC_LN, nRPC_OS);
}

function calcRPC(nPeriods, nSmoothing, nOB, nOS, nUpperNZ, nLowerNZ, iDecimals ) {
    var nC = close(0);
    var OB = ema(nSmoothing, efsInternal("calcCord", nPeriods, nOB),      0);
    var UN = ema(nSmoothing, efsInternal("calcCord", nPeriods, nUpperNZ), 0);
    var LN = ema(nSmoothing, efsInternal("calcCord", nPeriods, nLowerNZ), 0);
    var OS = ema(nSmoothing, efsInternal("calcCord", nPeriods, nOS),      0);
 

denom = Math.pow(10, iDecimals);


    OB = nC - (nC * (OB/denom));
    UN = nC - (nC * (UN/denom));
    LN = nC - (nC * (LN/denom));
    OS = nC - (nC * (OS/denom));
    
    return new Array(OB, UN, LN, OS);
}


function calcCord(nPeriods, nCord) {
    return (rsi(nPeriods, 0) - nCord);
}


function verify() {
    var b = false;
    if (getBuildNumber() < 730) {
        drawTextAbsolute(5, 35, "This study requires version 7.9.1 or later.", 
            Color.white, Color.blue, Text.RELATIVETOBOTTOM|Text.RELATIVETOLEFT|Text.BOLD|Text.LEFT,
            null, 13, "error");
        drawTextAbsolute(5, 20, "Click HERE to upgrade.@URL=http://www.esignal.com/download/default.asp", 
            Color.white, Color.blue, Text.RELATIVETOBOTTOM|Text.RELATIVETOLEFT|Text.BOLD|Text.LEFT,
            null, 13, "upgrade");
        return b;
    } else {
        b = true;
    }
    
    return b;
}

// ADDED FUNCTIONS

function editParameters() {
    askForInput("TRO_wilson_rpc");
    return;
}


// rnd function - round to iDecimals places
function rnd(value, iDecimals ) {  

value =  value * Math.pow(10, iDecimals);

    return Math.round(value, iDecimals) / Math.pow(10, iDecimals);
} 

[pmurraymc]

Buzz,

I thought you might take up the challenge, like the colours as well.

My team won the cricket and I got a little sun as well, must get out of my dungeon more often.

Paul.

[pmurraymc]

This is a similar peice of code from BB but just does the one line for the value of RSI you select.

Interesting fact: the reverse engineering of a 50 value of a 14 period RSI is eqivalent to a 28 period ema (just tested that out to make sure I'm not talking rubbish).

This is maybe why Buzz's combination of a 2 period RSI and a 5 (could go to a 4 ema if above followed) period ema works well together.

Paul.

[buzzhorton]

I can't get it to plot!

[pmurraymc]

Hi Buzz,

just realised, all my chart backgrounds are grey and this is a white line - I guess your backgrounds are white.

Sorry about that.

Paul.