converting an expression into a serial object

[scjohn]

I am having some difficulties in converting an expression into a serial object. The expression is

    nPRHigh = hhv(fpLength, high());
    nPRLow = llv(fpLength, low());
    nPRPrice = ( hhv(fpLength, high()) + llv(fpLength, low()) + close() ) / 3.0; 
return new Array(nPRPrice, nPRHigh, nPRLow ); 

so far I got

// global variables
var bInit = false;  //initialization flag
var nPRPrice = null;     //Pivot Range Price
var nPRHigh = null;      //Pivot Range High
var nPRLow = null;       //Pivot Range low

function main(fpSymbol, fpInterval, fpPT1, fpPS1, fpThick1, fpColor1, fpPT2, fpPS2, fpThick2, fpColor2, fpPT3, fpPS3, fpThick3, fpColor3, fpPVar, fpLength)
{
    // one time initialization
    if(bInit == false){
        if(fpSymbol == null) fpSymbol = getSymbol();
        if(fpInterval == null) fpInterval = getInterval();

    var vSymbol = fpSymbol + "," + fpInterval;
    nPRHigh = hhv(fpLength, high(sym(vSymbol)) );
    nPRLow = llv(fpLength, low(sym(vSymbol)) );
    nPRPrice = 
    bInit = true;
    }   //end of initialization  
//nPRPrice = ( hhv(fpLength, high()) + llv(fpLength, low()) + close() ) / 3.0;

return new Array(nPRPrice, nPRHigh, nPRLow ); 

I have to admit that I'm stuck in converting
( hhv(fpLength, high()) + llv(fpLength, low()) + close() ) / 3.0;
to work with series.

Thanks

[ACM]

scjohn
If you move hhv() and llv() out of the bInit statement they appear to work

var bInit = false;
var nPRPrice = null;
var nPRHigh = null;
var nPRLow = null;
var Symbol = null;

function main(fpSymbol, fpInterval, fpLength){

    if(fpLength==null) fpLength=10;

    if(bInit == false){
        if(fpSymbol == null) fpSymbol = getSymbol();
        if(fpInterval == null) fpInterval = getInterval();
        var vSymbol = fpSymbol + "," + fpInterval;
        Symbol = vSymbol;
        //nPRHigh = hhv(fpLength, high(sym(vSymbol)) );
        //nPRLow = llv(fpLength, low(sym(vSymbol)) ); 
        bInit = true;
    }
    
    nPRHigh = hhv(fpLength, high(sym(Symbol)));
    nPRLow  = llv(fpLength, low(sym(Symbol)));
    nPRPrice = ( nPRHigh + nPRLow + close(sym(Symbol)) ) / 3.0;

    return new Array(nPRPrice, nPRHigh, nPRLow );
} 

While waiting for a fix if you want to maintain the functions inside the bInit statement you can use upperDonchian() in place of hhv() and lowerDonchian() in place of llv() and the returned values will be identical (compare it using the script below)
Alex

var bInit = false;
var nPRPrice = null;
var nPRHigh = null;
var nPRLow = null;
var Symbol = null;

function main(fpSymbol, fpInterval, fpLength){

    if(fpLength==null) fpLength=10;

    if(bInit == false){
        if(fpSymbol == null) fpSymbol = getSymbol();
        if(fpInterval == null) fpInterval = getInterval();
        var vSymbol = fpSymbol + "," + fpInterval;
        Symbol = vSymbol;
        nPRHigh = upperDonchian(fpLength, high(sym(Symbol)) );
        nPRLow = lowerDonchian(fpLength, low(sym(Symbol)) );
        bInit = true;
    }
    
    //nPRHigh = hhv(fpLength, high(sym(Symbol)));
    //nPRLow  = llv(fpLength, low(sym(Symbol)));
    nPRPrice = ( getSeries(nPRHigh) + getSeries(nPRLow) + close(sym(Symbol)) ) / 3.0;

    return new Array(nPRPrice, nPRHigh, nPRLow );
} 

[scjohn]

Alexis,

It would appear that hhv() and llv() have problems outside of binit statement.

I get two lines of ouput

High: 0 Low: 0
High: 595 Low: 586.9

And nothing appears on the chart.

I right click on chart the click Reload, I see: PivotRange, loading data.

    nPRHigh = hhv(fpLength, high(sym(vSymbol)) );
    nPRLow = llv(fpLength, low(sym(vSymbol)) );
    debugPrintln("High: " +  nPRHigh + " Low: " + nPRLow);
    nPRPrice = ( nPRHigh + nPRLow + close(sym(vSymbol)) ) / 3.0;

    return new Array(nPRPrice, nPRHigh, nPRLow ); 

[ACM]

scjohn
That is because vSymbol needs to be a global variable. That is why I added var Symbol = null; as an external (ie global) variable and then inside bInit I added Symbol = vSymbol. Try running the sample script I posted earlier and you should see that it works
Alex