Comparing 2 Mom periods

[pj909]

Nothing plots. I think the problem is how I'm creating the series.

// comapring two Mom periods

var xFastMom = null;
var xSlowMom = null;
var xMACD = null;
var xSig = null;
var xHist = null;
var bInit = false;


function preMain() {
    setPlotType( PLOTTYPE_LINE, 0 ); 
    setPlotType( PLOTTYPE_LINE, 1 ); 
    setPlotType( PLOTTYPE_HISTOGRAM, 2 ); 
    setDefaultBarFgColor( Color.blue, 0 );
    setDefaultBarFgColor( Color.red, 1 );
    setDefaultBarFgColor( Color.grey, 2 );
    }

function main() {
if (!bInit) {
        xFastMom = ema(6, mom(12) );
        xSlowMom = ema(6, mom(26) );
        xMACD = efsInternal("fGetMACD", xFastMom, xSlowMom);
        xSig = ema(9, getSeries(xMACD) );
        xHist = getSeries(xMACD) - getSeries(xSig);
        bInit = true;
    }
    
    return new Array( getSeries(xMACD), getSeries(xSig), getSeries(xHist) );
}

function fGetMACD(xF, xS){
    nF = xF.getValue(0);
    nS = xS.getValue(0);
    return(nF-nS);
} 

[ACM]

pj909
In the following line of code the getSeries() function is not required to call the xMACD series as this is being passed within the initialization routine [and the efsInternal() call is returning a single series anyhow]



You can pass the xMACD series directly to the ema() function as shown below



The following line of code



should be located outside of the initialization routine else it will be executed only once.
Furthermore you should retrieve the values from each series rather than calling the series eg



In the following line of code



you are incorrectly calling xHist as if it were a series which it is not. When you use one or more series within an expression the result is not a series but a value
Additionally as I believe I have already explained to you in the past [you may want to search through your own posts] unless you are basing your study on external intervals and/or symbols [whereby you want the efs engine to maintain the synchronization of the plots] you do not need to plot the series [and for that matter even call it] but should plot its values that you retrieve using the getValue() method of the series object
That line of code should be as follows



Once you implement the suggested changes the formula will work
I would also suggest that you search the forums as there are many examples of studies on studies available since the subject has been covered at length before [including in some of your own threads and if I remember correctly on this very same topic]
Alex

Nothing plots. I think the problem is how I'm creating the series.

// comapring two Mom periods

var xFastMom = null;
var xSlowMom = null;
var xMACD = null;
var xSig = null;
var xHist = null;
var bInit = false;


function preMain() {
    setPlotType( PLOTTYPE_LINE, 0 ); 
    setPlotType( PLOTTYPE_LINE, 1 ); 
    setPlotType( PLOTTYPE_HISTOGRAM, 2 ); 
    setDefaultBarFgColor( Color.blue, 0 );
    setDefaultBarFgColor( Color.red, 1 );
    setDefaultBarFgColor( Color.grey, 2 );
    }

function main() {
if (!bInit) {
        xFastMom = ema(6, mom(12) );
        xSlowMom = ema(6, mom(26) );
        xMACD = efsInternal("fGetMACD", xFastMom, xSlowMom);
        xSig = ema(9, getSeries(xMACD) );
        xHist = getSeries(xMACD) - getSeries(xSig);
        bInit = true;
    }
    
    return new Array( getSeries(xMACD), getSeries(xSig), getSeries(xHist) );
}

function fGetMACD(xF, xS){
    nF = xF.getValue(0);
    nS = xS.getValue(0);
    return(nF-nS);
} 

[pj909]

Thank you Alex.

[ACM]

pj909
You are welcome
Alex

Thank you Alex.